Fix image builds that don't use --build-arg - #1936
Conversation
As part of the shellcheck fixes, this variable was quoted. However, when the variable is empty this results in a bogus parameter being passed to podman build which caused it to fail. This appears to have been designed so it could be concatenated, but the variable is reset each time through the loop so I don't think we actually need that. This splits the argument name from its value so we pass valid arguments even when the variable is empty. Passing --build-arg '' seems to work fine with the image build I tested.
|
/lgtm |
|
/approve Dual stack failed on something unrelated, and it's not clear to me that CI would even exercise this code path. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@cybertron: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
As part of the shellcheck fixes, this variable was quoted. However, when the variable is empty this results in a bogus parameter being passed to podman build which caused it to fail.
This appears to have been designed so it could be concatenated, but the variable is reset each time through the loop so I don't think we actually need that. This splits the argument name from its value so we pass valid arguments even when the variable is empty. Passing --build-arg '' seems to work fine with the image build I tested.